Add documentation for aamtest test type#58632
Add documentation for aamtest test type#58632spectranaut merged 4 commits intoacacia-wdspec-style-testsfrom
Conversation
spectranaut
force-pushed
the
acacia-wdspec-documentation
branch
from
0d25dde to
422e4f4
Compare
|
@cookiecrook do you want to take a look at this? |
spectranaut
force-pushed
the
acacia-wdspec-style-tests
branch
from
bade881 to
a6d23f7
Compare
spectranaut
force-pushed
the
acacia-wdspec-documentation
branch
from
b307ca9 to
59b45e9
Compare
spectranaut
force-pushed
the
acacia-wdspec-style-tests
branch
from
1875b95 to
5af5f5f
Compare
There was a problem hiding this comment.
There's a mismatch between the commented subrole expectation from the spec (<nil>) and the asserted value (AXUnknown). I haven't looked into whether this is an actual problem, but even if not, it could use a comment explaining the mismatch.
There was a problem hiding this comment.
Ah good catch. I made an issue for that on core-aam! w3c/core-aam#259
There was a problem hiding this comment.
Should this either stub out the others (Edge, Safari, etc) or add a comment explaining that future expectation?
There was a problem hiding this comment.
Added a todo on the original PR.
There was a problem hiding this comment.
Can this one verify it's the tab with the test URL like you do in atspi_wrapper.py? Or add a TODO in case the lack of that verification step makes it flaky?
There was a problem hiding this comment.
Added TODO in the original PR.
There was a problem hiding this comment.
I tried to add this as a mergable suggestion, but GH is having trouble.
Closing tag is </div> but should be </button>
There was a problem hiding this comment.
ooo nice catch ty!
|
|
||
| * [aamtest][] tests are written in Python and test accessibility API mappings, | ||
| such as [Core Accessibility API Mappings](https://w3c.github.io/core-aam/) | ||
| or [HTML Accessibility API Mappings](https://w3c.github.io/core-aam/). |
There was a problem hiding this comment.
| or [HTML Accessibility API Mappings](https://w3c.github.io/core-aam/). | |
| or [HTML Accessibility API Mappings](https://w3c.github.io/html-aam/). |
spectranaut
force-pushed
the
acacia-wdspec-style-tests
branch
from
3678cc1 to
f89b949
Compare
spectranaut
force-pushed
the
acacia-wdspec-documentation
branch
from
59b45e9 to
bda939b
Compare
spectranaut
force-pushed
the
acacia-wdspec-documentation
branch
from
bda939b to
56d7b55
Compare
spectranaut
merged commit a2d6005
into
acacia-wdspec-style-tests
|
|
||
| The aamtest tests are used to verify the mapping of web content to | ||
| browser-exposed platform-specific accessibility APIs. These mappings are | ||
| specified by the ARIA working group of the W3C in the following specifications: |
There was a problem hiding this comment.
Not just ARIA WG for the extension specs like DPUB and PDF.
|
|
||
| ## Platform-Specific Accessibility APIs | ||
|
|
||
| Accessibility APIs are platform specific, each platform has their own API |
There was a problem hiding this comment.
Maybe add “or OS” here too, since some people don’t use the terms “platform” and “OS” as interchangeably as you and I do?
| * The name of the pytest fixture that returns access to the API (if you are | ||
| on the correct platform). | ||
| * The platform of that API. | ||
| * The python library that provides bindings to query the API. |
There was a problem hiding this comment.
Should Python be capitalized here to match your other proper noun terms?
4 participants
Add documentation for test type introduced in: #57696
See the RFC: web-platform-tests/rfcs#204